Discussion:
[389-users] plugin naming
Angel Bosch Mora
2021-05-10 12:46:36 UTC
Permalink
hi,

I vaguely remember discussing this some time ago but I can't find it now.


what's the difference between

dsconf myinstance plugin set --enabled on "Retro Changelog Plugin"

and

dsconf myinstance plugin retro-changelog enable

?


any of them is gonna be deprecated?

I also noticed that short name is different between versions/distributions (retro-changelog vs retrochangelog), so I prefer to use "Retro Changelog Plugin" if possible for scripting purpouses.
is that the right way to do it?

best regards,

abosch


-- Institut Mallorqui d'Afers Socials. Aquest missatge, i si escau, qualsevol fitxer annex, es dirigeix exclusivament a la persona que n'es destinataria i pot contenir informacio confidencial. En cap cas no heu de copiar aquest missatge ni lliurar-lo a terceres persones sense permis expres de l'IMAS. Si no sou la persona destinataria que s'hi indica (o la responsable de lliurar-l'hi) us demanam que ho notifiqueu immediatament a l'adreca electronica de la persona remitent. Abans d'imprimir aquest missatge, pensau si es realment necessari.
_______________________________________________
389-users mailing list -- 389-***@lists.fedoraproject.org
To unsubscribe send an email to 389-users-***@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-***@lists.fedoraproject.org
Do not reply to spam on the list, report it: https://pagure
Marc Sauton
2021-05-10 19:31:23 UTC
Permalink
the first is a more general plugin command, using the CN value of the
plugin name, should be consistent between releases, but can be easily
customized in the dse.ldif config file when an instance is deployed.
the second is dedicated to the "specific" plugins, it is a more recent
Python code, the class is called retrochangelog, but the sub command is
called retro-changelog, this should also stay consistent.
just 2 different ways to do the same thing, with more control in the second
form for those special plugins.
if this is about enabling or disabling a plugin, may be the first form is
better,
for managing particular features of the special plugins like memberof,
automember, referential-integrity, and some others, use the second form, or
the cockpit web UI.

there were a few changes in March 2019 , some cosmetic, to have the
"dedicated/special" plugins sub commands more consistent and more readable
using the same format with a dash when they have composed words:
Issue 50041 - Add CLI functionality for special plugins
https://github.com/389ds/389-ds-base/commit/46e28cb4229f590c225f2a52bc8169e6fcc2d65b
like
cmdName="retrochangelog"
cmdName="retro-changelog"

this is an active project, and the Python CLI was subject to more
disruptive changes in 2019 than today when it was really new, with version
1.4.0, before the RHEL-8 introduction in May 2019, not as stable as now,
it was likely the right time to have this change.
and not subject to change anytime soon.

is it possible a 389-ds-base-1.4.0 from before March 2019 till lurking
around?

Cordially,
Marc S.
Post by Angel Bosch Mora
hi,
I vaguely remember discussing this some time ago but I can't find it now.
what's the difference between
dsconf myinstance plugin set --enabled on "Retro Changelog Plugin"
and
dsconf myinstance plugin retro-changelog enable
?
any of them is gonna be deprecated?
I also noticed that short name is different between versions/distributions
(retro-changelog vs retrochangelog), so I prefer to use "Retro Changelog
Plugin" if possible for scripting purpouses.
is that the right way to do it?
best regards,
abosch
-- Institut Mallorqui d'Afers Socials. Aquest missatge, i si escau,
qualsevol fitxer annex, es dirigeix exclusivament a la persona que n'es
destinataria i pot contenir informacio confidencial. En cap cas no heu de
copiar aquest missatge ni lliurar-lo a terceres persones sense permis
expres de l'IMAS. Si no sou la persona destinataria que s'hi indica (o la
responsable de lliurar-l'hi) us demanam que ho notifiqueu immediatament a
l'adreca electronica de la persona remitent. Abans d'imprimir aquest
missatge, pensau si es realment necessari.
_______________________________________________
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
https://pagure.io/fedora-infrastructure
Angel Bosch Mora
2021-05-11 07:41:24 UTC
Permalink
Post by Marc Sauton
it was likely the right time to have this change.
and not subject to change anytime soon.
is it possible a 389-ds-base-1.4.0 from before March 2019 till
lurking
around?
I'm using debian packages:

dpkg -l | grep 389-ds-base
ii 389-ds-base 1.4.4.11-1 amd64 389 Directory Server suite - server
ii 389-ds-base-libs:amd64 1.4.4.11-1 amd64 389 Directory Server suite - libraries


they seem pretty new to me.

abosch
-- Institut Mallorqui d'Afers Socials. Aquest missatge, i si escau, qualsevol fitxer annex, es dirigeix exclusivament a la persona que n'es destinataria i pot contenir informacio confidencial. En cap cas no heu de copiar aquest missatge ni lliurar-lo a terceres persones sense permis expres de l'IMAS. Si no sou la persona destinataria que s'hi indica (o la responsable de lliurar-l'hi) us demanam que ho notifiqueu immediatament a l'adreca electronica de la persona remitent. Abans d'imprimir aquest missatge, pensau si es realment necessari.
_______________________________________________
389-users mailing list -- 389-***@lists.fedoraproject.org
To unsubscribe send an email to 389-users-***@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-***@lists.fedoraproject.org
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
Marc Sauton
2021-05-11 17:58:28 UTC
Permalink
and that should have:
https://github.com/389ds/389-ds-base/blob/master/src/lib389/lib389/cli_conf/plugins/retrochangelog.py
def create_parser(subparsers):
retrochangelog = subparsers.add_parser('retro-changelog', help='Manage
and configure Retro Changelog plugin')

Thanks,
Marc S.
Post by Angel Bosch Mora
Post by Marc Sauton
it was likely the right time to have this change.
and not subject to change anytime soon.
is it possible a 389-ds-base-1.4.0 from before March 2019 till lurking
around?
dpkg -l | grep 389-ds-base
ii 389-ds-base 1.4.4.11-1
amd64 389 Directory Server suite - server
ii 389-ds-base-libs:amd64 1.4.4.11-1
amd64 389 Directory Server suite - libraries
they seem pretty new to me.
abosch
-- Institut Mallorqui d'Afers Socials. Aquest missatge, i si escau,
qualsevol fitxer annex, es dirigeix exclusivament a la persona que n'es
destinataria i pot contenir informacio confidencial. En cap cas no heu de
copiar aquest missatge ni lliurar-lo a terceres persones sense permis
expres de l'IMAS. Si no sou la persona destinataria que s'hi indica (o la
responsable de lliurar-l'hi) us demanam que ho notifiqueu immediatament a
l'adreca electronica de la persona remitent. Abans d'imprimir aquest
missatge, pensau si es realment necessari.
_______________________________________________
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
https://pagure.io/fedora-infrastructure
Angel Bosch Mora
2021-05-12 12:57:20 UTC
Permalink
ok, I understand.

Can I suggest that this form

dsconf myinstance plugin retro-changelog enable

also accepts CN value as plugin name?

it would be easier than jumping from one syntax to another.

I can open a bug/issue if you want.

best regards,

abosch



----- Missatge original -----
Enviats: Dimarts, 11 de Maig 2021 19:58:28
Assumpte: [389-users] Re: plugin naming
https://github.com/389ds/389-ds-base/blob/master/src/lib389/lib389/cli_conf/plugins/retrochangelog.py
retrochangelog = subparsers.add_parser('retro-changelog',
help='Manage
and configure Retro Changelog plugin')
Thanks,
Marc S.
On Tue, May 11, 2021 at 12:51 AM Angel Bosch Mora
Post by Angel Bosch Mora
Post by Marc Sauton
it was likely the right time to have this change.
and not subject to change anytime soon.
is it possible a 389-ds-base-1.4.0 from before March 2019 till lurking
around?
dpkg -l | grep 389-ds-base
ii 389-ds-base 1.4.4.11-1
amd64 389 Directory Server suite - server
ii 389-ds-base-libs:amd64 1.4.4.11-1
amd64 389 Directory Server suite - libraries
they seem pretty new to me.
abosch
-- Institut Mallorqui d'Afers Socials. Aquest missatge, i si escau,
qualsevol fitxer annex, es dirigeix exclusivament a la persona que n'es
destinataria i pot contenir informacio confidencial. En cap cas no heu de
copiar aquest missatge ni lliurar-lo a terceres persones sense permis
expres de l'IMAS. Si no sou la persona destinataria que s'hi indica (o la
responsable de lliurar-l'hi) us demanam que ho notifiqueu
immediatament a
l'adreca electronica de la persona remitent. Abans d'imprimir aquest
missatge, pensau si es realment necessari.
_______________________________________________
To unsubscribe send an email to
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
https://fedoraproject.org/wiki/Mailing_list_guidelines
https://pagure.io/fedora-infrastructure
_______________________________________________
To unsubscribe send an email to
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
https://fedoraproject.org/wiki/Mailing_list_guidelines
https://pagure.io/fedora-infrastructure
-- Institut Mallorqui d'Afers Socials. Aquest missatge, i si escau, qualsevol fitxer annex, es dirigeix exclusivament a la persona que n'es destinataria i pot contenir informacio confidencial. En cap cas no heu de copiar aquest missatge ni lliurar-lo a terceres persones sense permis expres de l'IMAS. Si no sou la persona destinataria que s'hi indica (o la responsable de lliurar-l'hi) us demanam que ho notifiqueu immediatament a l'adreca electronica de la persona remitent. Abans d'imprimir aquest missatge, pensau si es realment necessari.
_______________________________________________
389-users mailing list -- 389-***@lists.fedoraproject.org
To unsubscribe send an email to 389-users-***@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-***@lists.fedoraproject.org
Do not reply to spam on the list, report it: h

Loading...